Skip to content

chore: drop old stdlib plugin in favour of internal project #23202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented May 20, 2025

We recompile scala 2 files that still require the scala 2 compiler (files with @specialized + AnyVal).
We add them manually to the scala 2 jar.

This replaces the old copy-paste system that was less safe.

NOTE: MiMa compares against the jar and not the output folder. This is important as we want to guarantee that the shipped jar is compatible. Also, MiMa doesn't allow to specify multiple output directories as source.

@hamzaremmal hamzaremmal requested a review from sjrd May 20, 2025 12:52
@hamzaremmal hamzaremmal force-pushed the drop-stdlib-plugin branch 4 times, most recently from 8d8e95c to 2775ade Compare May 23, 2025 12:46
@sjrd sjrd force-pushed the drop-stdlib-plugin branch from d602f2f to b1f5dad Compare May 23, 2025 13:23
@hamzaremmal hamzaremmal marked this pull request as ready for review May 23, 2025 13:24
@hamzaremmal hamzaremmal enabled auto-merge May 23, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants